Features added #15
Merged
Features added #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following features are added: 1) Threshold can now set by the user. 2) Pascal VOC saving format 3) Add all classes at once without selecting each manually
|
Hi @QuickLearner171998! Thank you for lending a hand in implementing these features. I haven't set-up CI yet so I will have to manually test it. Once done, I will be able to merge the changes. Thank you! |
virajmavani
reviewed
Apr 11, 2020
virajmavani
reviewed
Apr 11, 2020
virajmavani
reviewed
Apr 11, 2020
|
These are some great changes! Thank you for contributing to the project! Once the changes have been made, I will go ahead and merge. Later, I am planning to refactor the whole project as it is abominable. I don't know what I was thinking when I wrote it 2 years back. If interested, we can make a Slack group for developers and chat over it so that anyone else can also join. |
|
Yes, that would be great!! |
|
Looks good enough. I will merge. Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#11
What does this implement/fix? Explain your changes.
Following features are added:
Any other comments?